arm64: account for imported funcs in the branch to a relocation island #2387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evacchi
force-pushed
the
trambapoline-offset
branch
from
9e689a4 to
4d40aaa
Compare
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
evacchi
force-pushed
the
trambapoline-offset
branch
from
4d40aaa to
7883781
Compare
|
thanks @ncruces for the help! |
|
the failure is unrelated, fixed with #2388 |
ncruces
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2382, follow up to #2346
In #2346 we forgot that the unconditional relative jump to the relocation island should account for the imported functions as well.